Skip to content

[PM-21184] Migrate free-bitwarden-families.component.html to Tailwind complying #14628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21184

📔 Objective

/apps/web/src/app/billing/members/free-bitwarden-families.component.html
67:27 error Classname 'm-0' is not a Tailwind CSS class! tailwindcss/no-custom-classname
76:31 error Classname 'pl-1' is not a Tailwind CSS class! tailwindcss/no-custom-classname
85:13 error Classname 'mt-0' is not a Tailwind CSS class! tailwindcss/no-custom-classname
90:13 error Classname 'mt-3' is not a Tailwind CSS class! tailwindcss/no-custom-classname

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner May 5, 2025 13:13
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.30%. Comparing base (37e1305) to head (cb27a94).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14628   +/-   ##
=======================================
  Coverage   36.30%   36.30%           
=======================================
  Files        3201     3201           
  Lines       93333    93333           
  Branches    16832    16832           
=======================================
  Hits        33880    33880           
  Misses      57009    57009           
  Partials     2444     2444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 5, 2025

Logo
Checkmarx One – Scan Summary & Detailsd4178503-8868-45ea-8ec1-90fc00b28fff

Great job, no security vulnerabilities found in this Pull Request

@cyprain-okeke cyprain-okeke requested review from a team as code owners May 19, 2025 13:00
@@ -82,6 +82,7 @@ import { SharedModule } from "./shared.module";
OrganizationLayoutComponent,
VerifyRecoverDeleteOrgComponent,
VaultTimeoutInputComponent,
NoItemsModule,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Please do not add to this list of declarations. If you are migrating components then please also remove them from here and make them standalone/add them to their own module

@cyprain-okeke cyprain-okeke requested a review from coroiu May 19, 2025 13:40
coroiu
coroiu previously approved these changes May 19, 2025
@cyprain-okeke cyprain-okeke requested a review from coroiu May 21, 2025 08:21
coroiu
coroiu previously approved these changes May 28, 2025
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving platform changes to loose-components

@cyprain-okeke cyprain-okeke requested review from coroiu and willmartian and removed request for a team and willmartian May 28, 2025 09:42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: it seems you completely erased the package-lock.json file :)

@coroiu
Copy link
Contributor

coroiu commented May 28, 2025

@cyprain-okeke you are probably resetting package-lock.json to your (old) local copy of main instead of origin/main

@cyprain-okeke cyprain-okeke requested a review from coroiu May 28, 2025 10:12
@cyprain-okeke cyprain-okeke removed the request for review from willmartian May 28, 2025 11:26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this file can be deleted since it is no longer used, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is still been used. Oscar suggested i revert the no-item change, so we revisit it later

@cyprain-okeke cyprain-okeke removed the request for review from amorask-bitwarden May 28, 2025 15:42
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we still modified loose-components or search.svg.

@willmartian willmartian dismissed their stale review June 2, 2025 15:28

No longer needed

Copy link

sonarqubecloud bot commented Jun 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants