[PM-21184] Migrate free-bitwarden-families.component.html to Tailwind complying #14628
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14628 +/- ##
=======================================
Coverage 36.30% 36.30%
=======================================
Files 3201 3201
Lines 93333 93333
Branches 16832 16832
=======================================
Hits 33880 33880
Misses 57009 57009
Partials 2444 2444 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job, no security vulnerabilities found in this Pull Request |
apps/web/src/app/billing/members/free-bitwarden-families.component.html
Outdated
Show resolved
Hide resolved
| @@ -82,6 +82,7 @@ import { SharedModule } from "./shared.module"; | |||
| OrganizationLayoutComponent, | |||
| VerifyRecoverDeleteOrgComponent, | |||
| VaultTimeoutInputComponent, | |||
| NoItemsModule, | |||
There was a problem hiding this comment.
issue: Please do not add to this list of declarations. If you are migrating components then please also remove them from here and make them standalone/add them to their own module
cyprain-okeke
requested review from
coroiu and
willmartian
and removed request for
a team and
willmartian
package-lock.json
Outdated
There was a problem hiding this comment.
issue: it seems you completely erased the package-lock.json file :)
|
@cyprain-okeke you are probably resetting |
apps/web/src/images/search.svg
Outdated
There was a problem hiding this comment.
I believe this file can be deleted since it is no longer used, right?
There was a problem hiding this comment.
The file is still been used. Oscar suggested i revert the no-item change, so we revisit it later
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21184
📔 Objective
/apps/web/src/app/billing/members/free-bitwarden-families.component.html
67:27 error Classname 'm-0' is not a Tailwind CSS class! tailwindcss/no-custom-classname
76:31 error Classname 'pl-1' is not a Tailwind CSS class! tailwindcss/no-custom-classname
85:13 error Classname 'mt-0' is not a Tailwind CSS class! tailwindcss/no-custom-classname
90:13 error Classname 'mt-3' is not a Tailwind CSS class! tailwindcss/no-custom-classname
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes